Skip to content

Converter : transmission du distributionID original pour la conversion RC-RI dans le sens 18-15#399

Merged
Clemsazert merged 4 commits into
converter/rc-ri-single-messagefrom
rc-ri-use-original-distribution-id
Apr 15, 2026
Merged

Converter : transmission du distributionID original pour la conversion RC-RI dans le sens 18-15#399
Clemsazert merged 4 commits into
converter/rc-ri-single-messagefrom
rc-ri-use-original-distribution-id

Conversation

@Clemsazert
Copy link
Copy Markdown
Contributor

@Clemsazert Clemsazert commented Apr 14, 2026 •
edited
Loading

🔎 Détails

  • Ajout du distributionID du message RC-RI original dans les messages convertis
  • Prise en compte des 2 cas :
    • si un RS-RI est généré, on lui fait porter le distributionID du message original
    • si aucun RS-RI n'est généré, le premier RS-SR généré porte le distributionID du message original

Chore :

  • Suppression d'une étape de post du coverage dans la PR présente en double dans la CI
  • Bump à la version latest de l'action de post du coverage

🔗 Ticket associé

Asana

@Clemsazert Clemsazert marked this pull request as ready for review April 14, 2026 16:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026 •
edited
Loading

Coverage

Converter - python code coverage
FileStmtsMissBranchBrPartCoverMissing
constants.py4000100% 
conversion_mixin.py2912196%26
converter.py6736195%26, 94–95
database.py32224431%12, 16, 18–21, 23, 25, 27, 29–38, 40–41, 49
logging_config.py3528294%29, 36
utils.py164374698%57, 108, 120
cisu
   base_cisu_converter.py3330090%7, 25, 31
   constants.py4000100% 
   identical_cisu_converter.py9000100% 
   utils.py15060100% 
cisu/create_case
   create_case_cisu_constants.py31000100% 
   create_case_cisu_converter.py145132199%112
cisu/reference
   reference_converter.py920077%9, 13
cisu/resources_info
   resources_info_cisu_constants.py9000100% 
   resources_info_cisu_converter.py157234298%163, 329
   resources_info_cisu_helper.py37310291%58, 63, 66
cisu/resources_status
   resources_status_constants.py3000100% 
   resources_status_converter.py3012096%30
conversion_strategy
   cisu_conversion_strategy.py49222295%68, 93
   conversion_strategy.py7020100% 
   health_conversion_strategy.py460240100% 
models
   persisted_message.py13000100% 
repositories
   message_repository.py701212282%90–91, 98, 118–120, 122–123, 125, 171–173
versions
   base_message_converter.py831214285%13, 72–74, 86, 98, 102, 106, 110, 114, 118, 124
   error_converter.py510080%7
   identical_message_converter.py15000100% 
   utils.py26512280%34–37, 43
versions/create_case_health
   constants.py4000100% 
   create_case_health_converter.py1780800100% 
   create_case_health_update_converter.py5000100% 
versions/create_case_health/v1_v2
   constants.py17000100% 
   utils.py460222100% 
versions/create_case_health/v2_v3
   constants.py29000100% 
versions/geo_positions_update
   geo_positions_update_constants.py4000100% 
   geo_positions_update_converter.py49312493%31, 42, 79
versions/geo_resources_details
   geo_resources_details_constants.py4000100% 
   geo_resources_details_converter.py27040100% 
versions/reference
   reference_constants.py2000100% 
   reference_converter.py13000100% 
versions/resources_engagement
   resources_engagement_constants.py3000100% 
   resources_engagement_converter.py22021100% 
versions/resources_info
   resources_info_constants.py20000100% 
   resources_info_converter.py870363100% 
versions/resources_request
   resources_request_constants.py2000100% 
   resources_request_converter.py21000100% 
versions/resources_response
   resources_response_constants.py4000100% 
   resources_response_converter.py16020100% 
versions/resources_status
   resources_status_constants.py10000100% 
   resources_status_converter.py39000100% 
TOTAL1729784223795% 

@Clemsazert Clemsazert changed the title test(converter): add distributionID checks on cisu to rs cases Converter : transmission du distributionID original pour la conversion RC-RI dans le sens 18-15 Apr 15, 2026
@Clemsazert Clemsazert force-pushed the rc-ri-use-original-distribution-id branch from 2fa2624 to 0de788b Compare April 15, 2026 07:30
@Clemsazert Clemsazert force-pushed the rc-ri-use-original-distribution-id branch from 0de788b to 684e54b Compare April 15, 2026 12:14
@ansforge ansforge deleted a comment from github-actions Bot Apr 15, 2026
@ansforge ansforge deleted a comment from github-actions Bot Apr 15, 2026
@ansforge ansforge deleted a comment from github-actions Bot Apr 15, 2026
@ansforge ansforge deleted a comment from github-actions Bot Apr 15, 2026
@ansforge ansforge deleted a comment from github-actions Bot Apr 15, 2026
@ansforge ansforge deleted a comment from github-actions Bot Apr 15, 2026
@ansforge ansforge deleted a comment from github-actions Bot Apr 15, 2026
@Clemsazert Clemsazert force-pushed the rc-ri-use-original-distribution-id branch from cb3f0f7 to 8e67200 Compare April 15, 2026 12:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

There is no coverage information present for the Files changed

Total Project Coverage 52.5% 🍏

@Clemsazert Clemsazert merged commit 5ea4276 into converter/rc-ri-single-message Apr 15, 2026
2 checks passed
@Clemsazert Clemsazert deleted the rc-ri-use-original-distribution-id branch April 15, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EliNoden EliNoden EliNoden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Clemsazert @EliNoden